Repository navigation
refactor: remove old apply_date_shifts - #159
Merged
Merged
Conversation
shift_inline is now passing all of the tests
- creates IDs anew - adjusts coverage rules
Member
|
Could you link the issue that this is relevant to? |
g-pechorin
marked this pull request as draft
October 14, 2026 15:14
- shift_excel_inplace is 15 lines - ... ignoring logs/docs, and multi-line calls - extracts the shifting logic itself - the handling of page/row changes is now a FSM - moved shared definitions into their own file - merges the shift-delta loading and generation - annotated with sheet_configs_t - added pyyaml dependency
…during unit testing
…f sensitive information' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
g-pechorin
marked this pull request as ready for review
October 19, 2026 10:02
AndyRae
approved these changes
Oct 22, 2026
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was recreated as part of the PR stack for date shift changes.
PR Description
Removes the old date shifting function and now unused subroutines, retargets unit tests from those to run the new
_inplacevariant, and, updates documentation.Related Issues or other material
Related #
Closes #165
Screenshots, example outputs/behaviour etc.
✅ Added/updated tests?
[optional] What gif best describes this PR or how it makes you feel?